[Typography] Added position only when Skeleton is a direct child #38799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: Typography
Netlify deploy previewhttps://deploy-preview-38799--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zanivan
reviewed
Sep 4, 2023
| <Avatar size="lg" src="/static/images/avatar/1.jpg" /> | ||
| <Link | ||
| overlay | ||
| href="#introduction" |
There was a problem hiding this comment.
I wonder why the link's href is #introduction—Doesn't it make more sense to be #overlay-prop?
There was a problem hiding this comment.
Oh, in this case, it does not matter. It's just a visual regression test, any #… works fine.
brijeshb42
approved these changes
Sep 5, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
anon-phantom
pushed a commit
to anon-phantom/material-ui
that referenced
this pull request
Sep 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #38701, added regression test to prevent the bug in the future.