New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint] Enforce spaced-comment #3910

Merged

mbrookes merged 1 commit into mui:master from oliviertassinari:eslint-enforce-spaced-comment

Apr 8, 2016

Member

oliviertassinari commented Apr 8, 2016

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Makes the comment spacing more consistent and follow the React source code / Airbnb js convention.


          [eslint] Enforce spaced-comment

c79874b

oliviertassinari added PR: Needs Review labels

Member

mbrookes commented Apr 8, 2016

Wow, we actually have some code comments! 😄

mbrookes added PR: Review Accepted and removed PR: Needs Review labels

mbrookes merged commit a64237e into mui:master

oliviertassinari deleted the eslint-enforce-spaced-comment branch

April 8, 2016 22:23

zannager added package: system package: eslint labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment