[docs][joy-ui] Revise the CSS vars page #39335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy preview
Bundle size report |
danilo-leal
commented
Oct 11, 2023
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Oct 17, 2023
siriwatknp
reviewed
Oct 17, 2023
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Oct 17, 2023
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Oct 17, 2023
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Oct 17, 2023
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
siriwatknp
approved these changes
Oct 18, 2023
1 task
|
@samuelsycamore — bumping this one up for a quick pass! 😬 |
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
|
|
||
| Use the `theme.vars.*` notation with any styling APIs supported by Joy UI: | ||
|
|
||
| ### styled function |
There was a problem hiding this comment.
Maybe we should links to the relevant docs for each of these sections? This page assumes that the reader knows what all of these are, which may not be the case.
There was a problem hiding this comment.
Added a success callout pointing to the Approaches page — what do you think?
(We might need to do a quick revision on that one, too, to ensure it covers all the styling APIs adequately, as well with demos for them... but for another PR!)
samuelsycamore
approved these changes
Oct 29, 2023
docs/data/joy/customization/using-css-variables/using-css-variables.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is motivated by a recent docs-feedback where folks have pointed out how the Usage page was saying something inaccurate. After tackling that, it felt like a great opportunity to poke at the CSS vars page and ensure everything was tidy there... Ended up finding this one super hard, though. I'm not fully sure whether the terminology I've used on the page is correct and if it's well-structured. @siriwatknp would appreciate some more technical validation on this one!
👉 https://deploy-preview-39335--material-ui.netlify.app/joy-ui/customization/using-css-variables/