Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove dependency on lodash.flowright #3955

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

newoga
Copy link
Contributor

@newoga newoga commented Apr 12, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

If recompose is here to stay, we might as well remove lodash.flowright and use the compose function that recompose exports (which happens to be lodash.flowright).

@nathanmarks
Copy link
Member

@nathanmarks
Copy link
Member

@newoga also, in lodash, compose is an alias for flowRight 😜

@nathanmarks nathanmarks merged commit 8492985 into mui:master Apr 12, 2016
@mbrookes
Copy link
Member

@nathanmarks - and there you were worrying abut us reexporting our own components. 😄

@newoga newoga deleted the remove-lodash.flowright branch June 7, 2016 04:17
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants