Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples][material-ui] Remove hardcoded color="black" from Next.js App Router layout #39577

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

samuelsycamore
Copy link
Member

Closes #39473 by removing color="black" from the Typography component at the top of layout.tsx so the colors will render correctly in light and dark modes.

@samuelsycamore samuelsycamore added package: material-ui Specific to @mui/material examples Relating to /examples nextjs labels Oct 23, 2023
@mui-bot
Copy link

mui-bot commented Oct 23, 2023

Netlify deploy preview

https://deploy-preview-39577--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6552992

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Left a tiny comment only 🤙

examples/material-ui-nextjs-ts/src/app/layout.tsx Outdated Show resolved Hide resolved
@samuelsycamore samuelsycamore merged commit 44705ce into mui:master Oct 25, 2023
19 checks passed
@samuelsycamore samuelsycamore deleted the fix-next-text branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples nextjs package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][examples] Component style overriding dark mode in Next.js App Router example
3 participants