[docs-infra] Fix settings drawer accessibility issues #39589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emamoah
commented
Oct 24, 2023
emamoah
commented
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-39589--material-ui.netlify.app/ Bundle size report |
zannager
added
docs
danilo-leal
changed the title
danilo-leal
added
scope: docs-infra
danilo-leal
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Hey there, @emamoah! Thanks for opening this issue — good catch!
One quick thing, though: have you checked whether we have actual labels for these seetings.* strings that are being pulled from the translation file?
|
@danilo-leal yes I have |
danilo-leal
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.