Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][docs] Fix wrong messages #39602

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[joy-ui][docs] Fix wrong messages #39602

merged 2 commits into from
Oct 27, 2023

Conversation

siriwatknp
Copy link
Member

I think these messages come with copy-pasting when I created new components and forgot to remove them.

@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Oct 25, 2023
@mui-bot
Copy link

mui-bot commented Oct 25, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39602--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c7e4b2c

danilo-leal
danilo-leal reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Is it okay to leave it empty, though, or should we replace them with something else?

@siriwatknp
Copy link
Member Author

siriwatknp commented Oct 26, 2023 •
edited

Good call! Is it okay to leave it empty, though, or should we replace them with something else?

I think it's okay to leave it empty in this PR. My intention is to remove the wrong messages.

danilo-leal
danilo-leal approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay — sounds good!

@siriwatknp siriwatknp merged commit 1bdfb14 into mui:master Oct 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriwatknp @mui-bot @danilo-leal