Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Make code readable to set next color in color inversion demos #39669

Conversation

ZeeshanTamboli
Copy link
Member

Slight syntax change: If the variable name is nextColor, the + 1 should be placed on it, not below it. The logic remains the same.

Feedback from https://mui-org.slack.com/archives/C050VE13HDL/p1698631933550839.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Oct 30, 2023
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review October 30, 2023 07:07
@mui-bot
Copy link

mui-bot commented Oct 30, 2023

Netlify deploy preview

https://deploy-preview-39669--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d01127f

@ZeeshanTamboli ZeeshanTamboli changed the title [docs][joy-ui] Make code readable to set next color in color inversion header section [docs][joy-ui] Make code readable to set next color in color inversion demos Oct 30, 2023
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let Jun give the word here! 😬 I'm not the best to pitch in on JavaScript readability 😅

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes more sense.

@ZeeshanTamboli ZeeshanTamboli merged commit d37b6cc into mui:master Nov 3, 2023
20 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the docs-joy-ui-improve-color-inversion-header-demo branch November 3, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants