Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Add comment about code to be removed from Drawer demo #39678

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

samuelsycamore
Copy link
Member

Closes #39667 by adding a comment next to the line that should be removed when copying and pasting the "Responsive Drawer" demo into an app. I also changed the "you won't need" comment to be more explicit that it should be removed.

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation component: drawer This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Oct 30, 2023
@mui-bot
Copy link

mui-bot commented Oct 30, 2023

Netlify deploy preview

https://deploy-preview-39678--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2c5bcb2

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads much better! 🤙

@samuelsycamore samuelsycamore merged commit b0280be into mui:master Oct 31, 2023
23 checks passed
@samuelsycamore samuelsycamore deleted the drawer-doc branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: window is not a function mui responsive drawer
3 participants