Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Speed up the CI by removing the second build #39684

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

michaldudak
Copy link
Member

Removed the second build of all the libraries as it's time-consuming (over 6 minutes). While testing if the build is idempotent is valuable, it feels that removing it could be a compromise between completeness and speed. It's not an area that often changes.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Oct 31, 2023
@michaldudak michaldudak requested a review from a team October 31, 2023 12:45
@mui-bot
Copy link

mui-bot commented Oct 31, 2023

Netlify deploy preview

https://deploy-preview-39684--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 60bbc8b

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I'm not even sure what it's exactly supposed to catch.

The real solution here will be running the publishing process in CI so that even if we have a bad cleanup, it won't affect public packages as it started from a fresh checkout anyway.

@michaldudak michaldudak merged commit d658fb3 into mui:master Nov 1, 2023
21 checks passed
@michaldudak michaldudak deleted the remove-second-ci-build branch November 1, 2023 08:41
@oliviertassinari
Copy link
Member

I'm adding #28361 as a comment, so it links the two PRs together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants