Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Improve access to the component demos via the API page #39690

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Oct 31, 2023

There has been more than one docs-feedback entry (here's an example of a recent one) in varying component API pages, requesting something like "I want to see demos, not just a list of props" as if we didn't provide the usual demo pages. So, this points out how we can call more attention to the "Demos" heading on the top of the API page to, hopefully, improve access to them.

To do that, on this PR, I'm wrapping in a success alert the content that was sitting under the "Demos" heading, as well as changing its title to be even more apparent (and slightly redundant, possibly).

馃憠 https://deploy-preview-39690--material-ui.netlify.app/joy-ui/api/accordion-summary/#demos

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Oct 31, 2023
@danilo-leal danilo-leal requested a review from a team October 31, 2023 22:32
@danilo-leal danilo-leal self-assigned this Oct 31, 2023
@mui-bot
Copy link

mui-bot commented Oct 31, 2023

Netlify deploy preview

https://deploy-preview-39690--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 馃毇 dangerJS against 93d9bbe

Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憣馃徎

@danilo-leal danilo-leal merged commit b601521 into mui:master Nov 1, 2023
22 checks passed
@danilo-leal danilo-leal deleted the api-page-demo-callout branch November 1, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants