Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Render footer in SSR #39710

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[docs-infra] Render footer in SSR #39710

merged 1 commit into from
Nov 2, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 2, 2023 •
edited

I have noticed this while I was looking at #39704.

  • Fix layout shift in https://mui.com/material-ui/getting-started/design-resources/ when loading the page. Overall, it feels like it makes more sense to SSR the footer. In the future, we might be able to make it a Server component. The alternative fix would be to simply force the scrollbar to reserve space.
  • Fix the animation by adding a <div>. Before
Screen.Recording.2023-11-02.at.02.02.04.mov

Preview: https://deploy-preview-39710--material-ui.netlify.app/material-ui/getting-started/design-resources/

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product labels Nov 2, 2023
@mui-bot
Copy link

mui-bot commented Nov 2, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39710--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against bd5d8f3

danilo-leal
danilo-leal approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better — thanks for tackling it! I had noticed this, too, but didn't know how to fix it. 🤙

@oliviertassinari oliviertassinari merged commit 0adb435 into mui:master Nov 2, 2023
20 checks passed
@oliviertassinari oliviertassinari deleted the footer-ssr branch November 2, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
Docs-infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-bot @danilo-leal