Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InputBase][material-next] InputBase slotProps accepts sx type #39714

Merged

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Nov 2, 2023

Part of #38372

This PR ports the fix in #39569 to material-next

@mj12albert mj12albert added package: material-ui Specific to @mui/material v6.x component: input This is the name of the generic UI component, not the React module! labels Nov 2, 2023
@mj12albert mj12albert changed the title [InputBase][material-next] slotProps accepts sx type [InputBase][material-next] InputBase slotProps accepts sx type Nov 2, 2023
@mui-bot
Copy link

mui-bot commented Nov 2, 2023

Netlify deploy preview

https://deploy-preview-39714--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e57b834

@mj12albert mj12albert marked this pull request as ready for review November 2, 2023 08:33
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't Material Next have slotProps types similar to Joy UI, as shown here? This will account for the sx type in each component's slotProps and thus we won't need to add it separately.

@mj12albert
Copy link
Member Author

Shouldn't Material Next have slotProps types similar to Joy UI

@ZeeshanTamboli It uses SlotComponentProps from Base UI, so we'd have to add these manually for now

Though we could probably modify SlotComponentProps to accept another type argument to handle this later

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Nov 2, 2023

Though we could probably modify SlotComponentProps to accept another type argument to handle this later

I meant to create a distinct type for Material Next, similar to Joy UI. This type can utilize Base UI's SlotComponentProps but also includes sx props. However, let's address this later.

@mj12albert mj12albert merged commit c832d21 into mui:master Nov 2, 2023
23 checks passed
@mj12albert mj12albert deleted the material-next/input-base-slotprops-sx branch November 2, 2023 14:11
@DiegoAndai DiegoAndai added v7.x and removed v6.x labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: input This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants