Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Fix incorrect state in getStyles() #3972

Merged
merged 1 commit into from
Apr 13, 2016
Merged

[TextField] Fix incorrect state in getStyles() #3972

merged 1 commit into from
Apr 13, 2016

Conversation

mbrookes
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

getStyles() was reading state, from context, so dynamic styling was not being applied correctly.

Fixes #3969.

@mbrookes
[TextField] Fix incorrect state in getStyles()
218d840 
getStyles() was reading state, from context, so dynamic styling was not being applied correctly.
@newoga newoga merged commit 8d124a5 into mui:master Apr 13, 2016
@mbrookes mbrookes deleted the textfield-fix-getstyle branch January 20, 2018 22:35
@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TextField] getStyles() not using theme from context
3 participants
@mbrookes @newoga @zannager