[joy-ui][docs] Update gif from the Dark Mode Optimization page #39726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy previewBundle size report |
|
I agree that the example of the bug on our site is not ideal, but I do really like the visual example to clarify the problem that this solves! Maybe we could replace it with an example of one our templates (that we break intentionally to show what happens)? |
|
That makes sense! @siriwatknp or @DiegoAndai would y'all be able to guide me on reproducing this bug on a random example so we can record a GIF to illustrate the problem? |
|
@danilo-leal something like this?: Screen.Recording.2023-11-20.at.16.56.50.movYou can force it in Joy templates by removing this line (and this one for the rest of the site). |
danilo-leal
changed the title
|
@DiegoAndai sweet! Ended up using exactly this video at the end 😬 — can I ask y'all to recheck this? |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 30, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says! Not only was that gif super small (sloppy-looking), but it was also a bit weird to use our homepage as an example of a bug we wanted to get rid of 😅
👉 https://deploy-preview-39726--material-ui.netlify.app/joy-ui/main-features/dark-mode-optimization/