Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Taiwan country name in demos #39729

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Conversation

chiahao
Copy link
Contributor

@chiahao chiahao commented Nov 3, 2023

Closes #39728

Fix Taiwan country name

Signed-off-by: Hao <hao.wu1980@gmail.com>
Fix Taiwan country in CountrySelect.tsx

Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
Signed-off-by: Hao <hao.wu1980@gmail.com>
@mui-bot
Copy link

mui-bot commented Nov 3, 2023

Netlify deploy preview

https://deploy-preview-39729--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ca3cb93

Copy link
Contributor Author

@chiahao chiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Taiwan country name.

@@ -88,6 +87,7 @@ The [Data Grid and Data Grid Pro](/x/react-data-grid/) components have their own
| Slovak | sk-SK | `skSK` |
| Spanish | es-ES | `esES` |
| Swedish | sv-SE | `svSE` |
| Taiwan | zh-TW | `zhTW` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiahao This column should refer to the name of the language though and not the country, so Chinese (Taiwan) should be accurate?

e.g. https://developers.google.com/admin-sdk/directory/v1/languages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry to bother you. Yes, you are right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mj12albert Do I have to revert this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done it ~

@mj12albert mj12albert added the docs Improvements or additions to the documentation label Nov 3, 2023
@mj12albert mj12albert changed the title Fix Taiwan country name [docs] Update Taiwan country name in demos Nov 3, 2023
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍 @chiahao

@mj12albert mj12albert merged commit a13c0c0 into mui:master Nov 6, 2023
20 checks passed
@hipages-guoxu

This comment was marked as abuse.

@mui mui locked as too heated and limited conversation to collaborators Nov 6, 2023
@oliviertassinari
Copy link
Member

To link back the history. We did a change around this in #34611

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 10, 2023

It looks like it's a sensitive topic lukes/ISO-3166-Countries-with-Regional-Codes#43.

ChatGTP answer to "What label should a country picker use for Taiwan?" is interesting.

The labeling of Taiwan can be a sensitive and politically charged issue due to the complex geopolitical situation involving Taiwan, China, and other countries. Different entities and organizations may use different labels based on their stance on the matter.

Some commonly used labels for Taiwan include:

- Taiwan: Some countries and organizations, especially those that maintain diplomatic relations with Taiwan or adopt a more neutral stance, use "Taiwan" as the label.

- Taiwan, Province of China: This label is often used in contexts where there is a recognition of the "One-China" policy, which asserts that there is only one China, and Taiwan is a part of it. This is the terminology commonly used by the United Nations and some international organizations.

- Chinese Taipei: In certain international events, Taiwan participates under the name "Chinese Taipei" to comply with the "One-China" policy without explicitly using the name Taiwan.

It's important to note that the choice of label can have diplomatic implications, and it's recommended to be aware of the political sensitivities involved. When implementing a country picker, it's advisable to use a label that aligns with the prevailing international standards and norms or to provide options that allow users to choose from different labels based on their preferences or perspectives.

From the historical perspective, https://en.wikipedia.org/wiki/History_of_Taiwan Taiwan seems to make more sense (in the doubt have people living there decide), however, from the perspective of we want to better tailor the library to meet where the Chinese community is at, Taiwan, Province of China would make more sense.

No strong preferences, I feel that the previous previous terminology was closer to the reality, so clearer, and more balanced "Taiwan, Republic of China" (a country within a larger country).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][joy-ui] Fix Taiwan country name in CountryPicker demo
5 participants