Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField][material-ui] Fix padding on small filled multiline TextField #39769

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Nov 6, 2023

Fixes #39610

I've adjusted the padding so that the small filled multiline hiddenInput TextField has the same 40px height and updated a regression test

Before: https://codesandbox.io/s/https-github-com-mui-material-ui-issues-39610-66xjhp?file=/src/App.tsx

Screenshot 2023-11-06 at 6 21 26 PM
The small one has larger padding than the medium one

After: https://codesandbox.io/s/https-github-com-mui-material-ui-pull-39769-5xpmzh?file=/src/App.tsx

Screenshot 2023-11-06 at 7 24 07 PM

@mj12albert mj12albert added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Nov 6, 2023
@mui-bot
Copy link

mui-bot commented Nov 6, 2023

Netlify deploy preview

https://deploy-preview-39769--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against b1710f8

@mj12albert mj12albert force-pushed the material/filled-multiline-textfield-padding branch from 299ce2d to b1710f8 Compare November 6, 2023 11:24
@mj12albert mj12albert marked this pull request as ready for review November 6, 2023 11:52
@mj12albert mj12albert changed the title [TextField][material-ui] Fix padding on small filled multiline variant [TextField][material-ui] Fix padding on small filled multiline TextField Nov 6, 2023
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🤙

@mj12albert mj12albert merged commit b7b2008 into mui:master Nov 7, 2023
20 checks passed
@mj12albert mj12albert deleted the material/filled-multiline-textfield-padding branch November 7, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][TextField] Multiline FilledInput has wrong padding problem when hiddenLabel={true}
4 participants