[joy-ui][docs] Fix menu in color inversion header demo #39785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewhttps://deploy-preview-39785--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
It should also close when clicking outside the Menu, not just when clicking the Main. Additionally, I believe the Menu should not be controlled by the Chip. According to the documentation, Chip is meant for data display, not as an input. I suggest changing it to MenuButton, as shown in the docs.
|
@ZeeshanTamboli argos change is expected as |
docs/data/joy/main-features/color-inversion/ColorInversionHeader.tsx
Outdated
Show resolved
Hide resolved
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainbuttonMain, menu is still open here. It should be closed, This PR fixes thatPreview https://deploy-preview-39785--material-ui.netlify.app/joy-ui/main-features/color-inversion/#header