Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog] Correct the Joy UI version in the changelog #39788

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

michaldudak
Copy link
Member

Corrected the Joy UI package version in the changelog.

Fixes #39784

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Nov 7, 2023
@mui-bot
Copy link

mui-bot commented Nov 7, 2023

Netlify deploy preview

https://deploy-preview-39788--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7cf0022

@oliviertassinari oliviertassinari changed the title [changelog] Correct the Joy UI version in the changelog [CHANGELOG] Correct the Joy UI version in the changelog Nov 7, 2023
@mnajdova mnajdova merged commit ecd261a into mui:master Nov 8, 2023
21 checks passed
@michaldudak
Copy link
Member Author

@oliviertassinari, why did you rename the PR? We don't use uppercase tags anywhere else.

@michaldudak michaldudak deleted the fix-joy-changelog-version branch November 8, 2023 08:57
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 8, 2023

@michaldudak Ok, fair enough: 17f4e04, mui/mui-x@4bb3df6. I think that [CHANGELOG] was more common historically, but lowercase is indeed with the rule we have. I think it's best not to have exceptions to keep the rule simple. Thanks for raising.

@oliviertassinari oliviertassinari changed the title [CHANGELOG] Correct the Joy UI version in the changelog [changelog] Correct the Joy UI version in the changelog Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] 5.14.17 release notes about joy ui version is wrong
4 participants