Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-next][ProgressIndicator] Change CircularProgress files to ts #39791

Merged
merged 13 commits into from
Nov 8, 2023
Merged

[material-next][ProgressIndicator] Change CircularProgress files to ts #39791

merged 13 commits into from
Nov 8, 2023

Conversation

lhilgert9
Copy link
Contributor

@lhilgert9 lhilgert9 commented Nov 7, 2023 •
edited

CircularProgress issue: #39770
Material You umbrella issue: #29345

Changes

  • Change CircularProgress files to TS
  • Fix ts errors
  • add missing svg classes

@lhilgert9 lhilgert9 mentioned this pull request Nov 7, 2023
Closed
7 tasks
@mui-bot
Copy link

mui-bot commented Nov 7, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39791--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 5e82f49

@lhilgert9 lhilgert9 marked this pull request as ready for review November 7, 2023 14:58
@zannager zannager added component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module! labels Nov 7, 2023
@danilo-leal danilo-leal added package: material-ui Specific to @mui/material v6.x labels Nov 7, 2023
mnajdova
mnajdova reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types looks good, let's just revert the unrelated changes so that it's easier to track the changes by pull request in the future.

packages/mui-material-next/src/CircularProgress/CircularProgress.tsx Outdated Show resolved Hide resolved
mnajdova
mnajdova approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tests are much better 👍

@mnajdova mnajdova merged commit efcdf73 into mui:master Nov 8, 2023
20 checks passed
@lhilgert9 lhilgert9 deleted the change-circular-progress-files-to-ts branch November 8, 2023 10:19
@DiegoAndai DiegoAndai added v7.x and removed v6.x labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lhilgert9 @mui-bot @mnajdova @DiegoAndai @danilo-leal @zannager