-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-next][ProgressIndicator] Apply MD3 style to LinearProgress
#39807
[material-next][ProgressIndicator] Apply MD3 style to LinearProgress
#39807
Conversation
Netlify deploy preview@mui/material-next: parsed: +1.71% , gzip: +1.31% Bundle size reportDetails of bundle changes (Toolpad) |
Regarding the animations: Example:
Does anyone have any ideas on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lhilgert9, thanks for working on these! Sorry for the delay in the review, I was OOO.
Left some questions. I also think we should add the playground in this PR, that way we can easily see the updated component.
packages/mui-material-next/src/LinearProgress/linearProgressClasses.ts
Outdated
Show resolved
Hide resolved
@DiegoAndai You mean the playground in the docs? |
Yes 👍🏼 |
@DiegoAndai Playground is implemented👍🏼 |
I'm bringing @zanivan into this as a design reviewer 😊 The specs default for the four-color option doesn't look good. I suggest choosing a better default on our side. If users want to use the specs, they can override the variables. What do you think @zanivan @lhilgert9? |
@DiegoAndai I agree with you that these don't look nice. Here we should also consider adding the additional inner-bar elements as already suggested (#39807 (comment)) |
I was digging further to understand why the material web looks different from our version, even though using the same colors: What I think that might have happened to their version look darker is that instead of |
@zanivan I tried it out and yes, it looks much better. What do you think about adding the inner-bar elements like in material-web to get the animation right, as I'm not really happy with the current one? |
Good one! It looks much better indeed 🙌
This will likely be better answered by @DiegoAndai, but IMO, if the structure with the inner-bar is better aligned with the new material design structure, maybe we should go for it? I mean, if it's not a huge breaking change. |
@DiegoAndai I would suggest that we merge this PR after review. Then we could open a new PR/draft and try the idea with the |
I agree ✅ Things missing to merge this PR are:
For this refactor:
Thanks @zanivan for the review and help with the four-color design 🎉 |
…o-linear-progress
I have now fixed these things. So this PR should now ready to merge.
I took another look at it and yes, it actually looks good the way it is right now. Let's just leave it as it is, then we won't have any more braking changes. |
Great job @lhilgert9! |
LinearProgress issue: #39778
Material You umbrella issue: #29345
Preview: https://deploy-preview-39807--material-ui.netlify.app/material-ui/react-progress/#material-you-version
Changes