Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Autocomplete] Add defaultMuiPrevented to onKeyDown type #39820

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[material-ui][Autocomplete] Add defaultMuiPrevented to onKeyDown type #39820

merged 1 commit into from
Nov 10, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Nov 9, 2023 •
edited

addresses: https://mui-org.slack.com/archives/C041SDSF32L/p1699372422138089

joy added defaultMuiPrevented type to Autocomplete onKeyDown, but it got missed in material ui Autocomplete.

material-ui/packages/mui-joy/src/Autocomplete/AutocompleteProps.ts

Lines 370 to 375 in 05652f6

type?: string;
onKeyDown?: (
event: React.KeyboardEvent<HTMLDivElement> & { defaultMuiPrevented?: boolean },
) => void;
}

@sai6855 sai6855 marked this pull request as draft November 9, 2023 13:22
@mui-bot
Copy link

mui-bot commented Nov 9, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39820--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0f7fbe1

@sai6855 sai6855 added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material component: autocomplete This is the name of the generic UI component, not the React module! typescript labels Nov 9, 2023
@sai6855 sai6855 changed the title [Autocomplete][material-ui] Add defaultMuiPrevented to type [Autocomplete][material-ui] Add defaultMuiPrevented to onKeyDown type Nov 9, 2023
@sai6855 sai6855 marked this pull request as ready for review November 9, 2023 14:21
ZeeshanTamboli
ZeeshanTamboli approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete][material-ui] Add defaultMuiPrevented to onKeyDown type [material-ui][Autocomplete] Add defaultMuiPrevented to onKeyDown type Nov 10, 2023
@ZeeshanTamboli
Copy link
Member

@sai6855 Note that the PR title convention has changed - [product-name][component-name].

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Autocomplete] Add defaultMuiPrevented to onKeyDown type [material-ui][Autocomplete] Add defaultMuiPrevented to onKeyDown type Nov 10, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 4398f9b into mui:master Nov 10, 2023
23 of 24 checks passed
@sai6855 sai6855 deleted the add-type-autocomplerte branch November 10, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sai6855 @mui-bot @ZeeshanTamboli