Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs][joy-ui] Add wordBreak style to demo #39821

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[Tabs][joy-ui] Add wordBreak style to demo #39821

merged 1 commit into from
Nov 10, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Nov 9, 2023 •
edited

Adding a very long word to this demo was breaking the styling of the Tab group, so CSS was used to fix it.

Before

Screenshot 2023-11-10 at 12 03 43 AM

After

Screenshot 2023-11-10 at 12 02 45 AM

@sai6855 sai6855 marked this pull request as draft November 9, 2023 17:33
@sai6855 sai6855 added docs Improvements or additions to the documentation component: tabs This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy enhancement This is not a bug, nor a new feature labels Nov 9, 2023
@mui-bot
Copy link

mui-bot commented Nov 9, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39821--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7bde3ca

@sai6855 sai6855 marked this pull request as ready for review November 9, 2023 18:34
zanivan
zanivan approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🤙

@mnajdova mnajdova merged commit 51bbadf into mui:master Nov 10, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sai6855 @mui-bot @zanivan @mnajdova