Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][Switch] Refine demos #39822

Merged
merged 4 commits into from
Nov 10, 2023
Merged

[base-ui][Switch] Refine demos #39822

merged 4 commits into from
Nov 10, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Nov 9, 2023 •
edited

Follow-up to #38820

Standardize the border and focus style on Base UI Switch demos

馃憠 https://deploy-preview-39822--material-ui.netlify.app/base-ui/react-switch/

@zanivan zanivan added component: switch This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Nov 9, 2023
@zanivan zanivan self-assigned this Nov 9, 2023
@mui-bot
Copy link

mui-bot commented Nov 9, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39822--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 馃毇 dangerJS against c849195

@zanivan
Copy link
Contributor Author

zanivan commented Nov 9, 2023

@mnajdova I fixed the focusVisible on all demos, but Tailwind demo seems to be ignoring the focus: prop. Do you know how it can be solved?

danilo-leal
danilo-leal approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 馃

@mnajdova
Copy link
Member

@zanivan the issue was because the focus is not on the element you want to style (it is on the hidden input). I used the group selector where I check for the Mui-focusVisible class on the parent, see d831bda. I hope this helps for future demos :)

@zanivan zanivan merged commit 94b4c4b into mui:master Nov 10, 2023
20 checks passed
oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this pull request Nov 11, 2023
@zanivan @mnajdova @oliviertassinari
[base-ui][Switch] Refine demos (mui#39822)
5e5d03b 
Co-authored-by: mnajdova <mnajdova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees

@zanivan zanivan

Labels
component: switch This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zanivan @mui-bot @mnajdova @danilo-leal