[material-next][ProgressIndicator] Apply MD3 style to CircularProgress
#39825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
added
component: CircularProgress
DiegoAndai
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Hey @lhilgert9! May I ask you to make the same adjustments we did with the LinearProgress PR?:
- Bring back color options including
inherit - Remove composed classes
- Add playground to make reviews easier
I don't know if I'm forgetting something. Thanks again for working on this!
|
@DiegoAndai I thought so, I just wanted to wait until the |
DiegoAndai
reviewed
Nov 30, 2023
docs/data/material/components/progress/ProgressMaterialYouPlayground.js
Outdated
Show resolved
Hide resolved
packages/mui-material-next/src/CircularProgress/CircularProgress.test.tsx
Show resolved
Hide resolved
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircularProgress issue: #39770
Material You umbrella issue: #29345
Preview: https://deploy-preview-39825--material-ui.netlify.app/material-ui/react-progress/#material-you-version
Changes
Known Issues
The animation is not implemented exactly as it looks in the MD3 docs. Other libraries have used many additional HTML elements for this. So the question here is whether it is worth the effort?
Example: