-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website][docs] Update the product identifier menu and X page #39832
[website][docs] Update the product identifier menu and X page #39832
Conversation
Netlify deploy previewhttps://deploy-preview-39832--material-ui.netlify.app/ Bundle size report |
@samuelsycamore heya! 👋 I've pushed in some copywriting changes in this PR as I revisited this page a bit — it'd be awesome if you could review it! The general thought process was to make the copy more inclusive to other advanced components, and slightly less Data Grid-centric, although it's still the main example used throughout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Trades, October 2020 | ||
</Typography> | ||
</Box> | ||
Trades, October 2020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah — but it's a good thing you called out. There are three instances of the Data Grid on this page, and they're all slightly differently customized. For the next one, I might tackle this to make sure they're all consistent, regardless of whether they're using different demo datasets!
<Box component="span" sx={visuallyHidden}> | ||
{label} | ||
</Box> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the point of this label since it's hidden and it does not add extra information because the label
text is exactly the same as the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siriwatknp — any guidance here, Jun? I didn't remove it because I followed the same pattern as in the ProductsSwitcher
file, which has this invisible label element. Should we keep it or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting effort to enhance the X landing page.
I am currently drafting the content for a new landing page that we aim to launch by March next year. Your support in bringing this new vision to life would be also greatly appreciated.
This PR adds all the currently available X components in the Docs menu, displayed on the marketing pages' navbar and the product identifier within the documentation switcher. I also took the opportunity to do some general tweaking here and there around the X page, mostly to display that all components are now stable. Other changes are fine-tuning stuff.
For the time being, these changes work well! Just acknowledging that, in the future, though, as we continue to add more components to the X suite, we may want to revisit a bunch of these items altogether (i.e., the docs switcher, the page content itself, that focuses a bit too much still on the Data Grid, etc.).
👉 https://deploy-preview-39832--material-ui.netlify.app/x