Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website][docs] Update the product identifier menu and X page #39832

Merged
merged 42 commits into from
Nov 29, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Nov 11, 2023

This PR adds all the currently available X components in the Docs menu, displayed on the marketing pages' navbar and the product identifier within the documentation switcher. I also took the opportunity to do some general tweaking here and there around the X page, mostly to display that all components are now stable. Other changes are fine-tuning stuff.

For the time being, these changes work well! Just acknowledging that, in the future, though, as we continue to add more components to the X suite, we may want to revisit a bunch of these items altogether (i.e., the docs switcher, the page content itself, that focuses a bit too much still on the Data Grid, etc.).

👉 https://deploy-preview-39832--material-ui.netlify.app/x

@danilo-leal danilo-leal added docs Improvements or additions to the documentation website Pages that are not documentation-related, marketing-focused. MUI X labels Nov 11, 2023
@danilo-leal danilo-leal self-assigned this Nov 11, 2023
@mui-bot
Copy link

mui-bot commented Nov 11, 2023

Netlify deploy preview

https://deploy-preview-39832--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 86a37e7

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 22, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 23, 2023
@danilo-leal
Copy link
Contributor Author

@samuelsycamore heya! 👋 I've pushed in some copywriting changes in this PR as I revisited this page a bit — it'd be awesome if you could review it! The general thought process was to make the copy more inclusive to other advanced components, and slightly less Data Grid-centric, although it's still the main example used throughout.

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

docs/src/components/productX/XComponents.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponentsSwitcher.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponentsSwitcher.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponentsSwitcher.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XPlans.tsx Show resolved Hide resolved
docs/src/components/productX/XPlans.tsx Show resolved Hide resolved
docs/src/components/productX/XPlans2.tsx Outdated Show resolved Hide resolved
docs/src/components/productMaterial/MaterialTemplates.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponents.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponentsSwitcher.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponentsSwitcher.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XComponentsSwitcher.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XDataGrid.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XPlans.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XRoadmap.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XTheming.tsx Outdated Show resolved Hide resolved
docs/src/components/productX/XTheming.tsx Outdated Show resolved Hide resolved
Trades, October 2020
</Typography>
</Box>
Trades, October 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for where is used this element let me notice that the hover color of the chip is a bit weird, because there is no on-click event. you can do a double click on the cell but nothing special on the chip.

Clearly out of the scope of this PR.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah — but it's a good thing you called out. There are three instances of the Data Grid on this page, and they're all slightly differently customized. For the next one, I might tackle this to make sure they're all consistent, regardless of whether they're using different demo datasets!

docs/src/components/productX/XGridFullDemo.tsx Outdated Show resolved Hide resolved
Comment on lines +81 to +83
<Box component="span" sx={visuallyHidden}>
{label}
</Box>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the point of this label since it's hidden and it does not add extra information because the label text is exactly the same as the description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siriwatknp — any guidance here, Jun? I didn't remove it because I followed the same pattern as in the ProductsSwitcher file, which has this invisible label element. Should we keep it or not?

Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting effort to enhance the X landing page.

I am currently drafting the content for a new landing page that we aim to launch by March next year. Your support in bringing this new vision to life would be also greatly appreciated.

@danilo-leal danilo-leal merged commit 039888d into mui:master Nov 29, 2023
22 checks passed
@danilo-leal danilo-leal deleted the updating-x-components-identifiers branch November 29, 2023 11:34
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 30, 2023
)

Co-authored-by: alexandre <alex.fauquette@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
)

Co-authored-by: alexandre <alex.fauquette@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
)

Co-authored-by: alexandre <alex.fauquette@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
)

Co-authored-by: alexandre <alex.fauquette@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
)

Co-authored-by: alexandre <alex.fauquette@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
)

Co-authored-by: alexandre <alex.fauquette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation MUI X website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants