[joy-ui][docs] Fix API generation for Grid #39861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
|
|
||
| mkdirSync(componentInfo.apiPagesDirectory, { mode: 0o777, recursive: true }); | ||
|
|
||
| return generateComponentApi(componentInfo, project, projectSettings); | ||
| return await generateComponentApi(componentInfo, project, projectSettings); |
There was a problem hiding this comment.
Missing for a clear error message
Netlify deploy previewBundle size report |
I was curious to understand why we were not generating the API for the Grid component. After looking at it for 1/4 hour, it turned out that there was no real serious reasons.
oliviertassinari
force-pushed
the
joy-add-grid-api
branch
from
826df93
to
00eb18a
Compare
oliviertassinari
added
bug 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #39159.
I first saw the issue in https://app.ahrefs.com/site-audit/3992793/63/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ccompliant%2CincomingAllLinks%2Corigin&filterId=91013c8aafad4fe1f7a0ad504eccad42&issueId=c64da643-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating.
And a few days later, my friend flagged me the issue:
I was also curious to understand why we were not generating the API for the Grid component. After looking at it for 1/4 hour, it turned out that there were no real serious reasons, I had to fix a bit the API generator though.
Before: https://mui.com/joy-ui/react-box/#api
After: https://deploy-preview-39861--material-ui.netlify.app/joy-ui/react-box/#api