Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Box] Added boxClasses #39889

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[material-ui][Box] Added boxClasses #39889

merged 2 commits into from
Nov 17, 2023

Conversation

sadik-malik
Copy link
Contributor

Added boxClasses for Box component in material-ui

Closes #39885

@mui-bot
Copy link

mui-bot commented Nov 15, 2023

Netlify deploy preview

https://deploy-preview-39889--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against d53612e

@zannager zannager added the component: Box The React component. label Nov 15, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we create pull request for the same for the system's and Joy UI's Box components? Thanks!

@ZeeshanTamboli ZeeshanTamboli added the package: material-ui Specific to @mui/material label Nov 16, 2023
@sadik-malik
Copy link
Contributor Author

@mnajdova raised separate PR for joy-ui #39895 and system #39896.

@mnajdova
Copy link
Member

Thanks, everything work as expected here: https://codesandbox.io/s/elastic-kilby-rhz3zw?file=/src/index.tsx

@mnajdova mnajdova merged commit 9a805ae into mui:master Nov 17, 2023
24 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Box The React component. package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boxClasses missing for Box component
5 participants