[system] Add outlineColor to defaultSxConfig #39962
Merged
+50
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-39962--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
Looks good to me! Should we also include it in the palette file for unstable_getThemeValue? I'm unsure why it's exported from MUI System for users. We have another getThemeValue in styleFunctionSx.
siriwatknp
reviewed
Nov 27, 2023
brijeshb42
force-pushed
the
fix/system-outline-color
branch
2 times, most recently
from
5846468
to
64f4a34
Compare
brijeshb42
force-pushed
the
fix/system-outline-color
branch
from
64f4a34
to
7af1bc0
Compare
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 30, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39491
Closes #33335