Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Downgrade lerna to 7.2.0 #40026

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

DiegoAndai
Copy link
Member

See: #40025

Downgrading lerna to 7.2.0 as it blocks release on its current version.

This has happened already in #39149, so I also blocked lerna renovate updates for now.

@DiegoAndai DiegoAndai added the core Infrastructure work going on behind the scenes label Nov 28, 2023
@DiegoAndai DiegoAndai requested review from a team November 28, 2023 13:22
@DiegoAndai DiegoAndai self-assigned this Nov 28, 2023
@mui-bot
Copy link

mui-bot commented Nov 28, 2023

Netlify deploy preview

https://deploy-preview-40026--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a264d6e

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DiegoAndai DiegoAndai merged commit baf5459 into mui:master Nov 28, 2023
20 checks passed
@DiegoAndai DiegoAndai deleted the downgrade-lerna branch November 28, 2023 14:21
{
"groupName": "Lerna",
"matchPackageNames": ["lerna"],
"enabled": false
Copy link
Member

@Janpot Janpot Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ideally has a "description" property with a short explanation on why it's disabled and a link to a github issue on the lerna repo.

It would also be slightly more useful to specify a maximum version instead of disabling it altogether

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a PR for doing so: #40029 😊

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 30, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants