[docs][material-ui] Update the basic Grid section copy #40035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current explanation is not correct and it's mixing actual browser window viewport term with the width of the parent grid container. Signed-off-by: Filip Malek <filamalek@hotmail.com>
Netlify deploy previewBundle size report |
danilo-leal
changed the title
danilo-leal
changed the title
danilo-leal
added
docs
|
WOw! thats nice |
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
samuelsycamore
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Thanks for raising this @REX500 ! I pushed a small grammar fix and a rewrite of the first sentence, because it wasn't clear to me what section it was referring to with "as you can read later in this page."
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Filip Malek <filamalek@hotmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Filip Malek <filamalek@hotmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Filip Malek <filamalek@hotmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Filip Malek <filamalek@hotmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current explanation is not correct and it's mixing actual browser window viewport term with the width of the parent grid container. Correct wording would be that
xs={12}, when added on a Grid element, would cause it to take 12 spaces of it's parent. We do not and cannot assume that the parent Grid element has width set to100vw. If the parent Grid has width set to 300px, for example, setting xs={12} on it's child would mean that that child occupies full width of the parent. In this case, given that parent Grid doesn't have any paddings and margins, would mean that the Grid has a width of 300px.