Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base-ui] Add tokens to plain CSS theme stylesheet #40113

Merged
merged 36 commits into from
Jan 5, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Dec 5, 2023

Part of: #40108

This PR is to add the theme tokens to the stylesheet and tweak the component's styling accordingly.

Preview: https://deploy-preview-40113--material-ui.netlify.app/experiments/base/components-gallery/

@zanivan zanivan added docs Improvements or additions to the documentation design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Dec 5, 2023
@zanivan zanivan self-assigned this Dec 5, 2023
@mui-bot
Copy link

mui-bot commented Dec 5, 2023

Netlify deploy preview

https://deploy-preview-40113--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8bf8505

@zanivan zanivan marked this pull request as draft December 6, 2023 13:53
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to add these configs to the settings panel long term?

docs/public/static/components-gallery/base-theme.css Outdated Show resolved Hide resolved
docs/pages/experiments/base/components-gallery.tsx Outdated Show resolved Hide resolved
docs/public/static/components-gallery/base-theme.css Outdated Show resolved Hide resolved
@zanivan
Copy link
Contributor Author

zanivan commented Dec 7, 2023

Do we plan to add these configs to the settings panel long term?

I think we could aim to adding some settings, like border-radius, a toggle for flat/elevated (where we remove box-shadows from buttons and inputs), and typography (I'm still figuring out the best way to add this to the stylesheet)

@zanivan zanivan marked this pull request as ready for review December 8, 2023 15:51
@zanivan
Copy link
Contributor Author

zanivan commented Dec 11, 2023

Just adding @mui/design on the loop! I'd love to hear your thoughts about the components' visual 😄

👉 https://deploy-preview-40113--material-ui.netlify.app/experiments/base/components-gallery/

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 added a few suggestions, the rest looks good.

docs/public/static/components-gallery/base-theme.css Outdated Show resolved Hide resolved
docs/public/static/components-gallery/base-theme.css Outdated Show resolved Hide resolved
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnajdova
Copy link
Member

The customization popup, is broken, the color switcher does not work anymore. I haven't look further, but wanted to raise that up. I can check it tomorrow if you need help Victor

@zanivan
Copy link
Contributor Author

zanivan commented Dec 19, 2023

The customization popup, is broken, the color switcher does not work anymore. I haven't look further, but wanted to raise that up. I can check it tomorrow if you need help Victor

Hey @mnajdova actually it's pretty broken everywhere 😅 —don't worry, though, it looks like this because @danilo-leal is adding some tweaks to the tokens, and I reckon he's still doing it haha. Anyway, I really appreciate the help, but I think after his tweaks we can merge this and work towards the next step: defining how we'll make it available for users.

@DiegoAndai
Copy link
Member

The Select component has to be updated because of #39675, as right now, it doesn't have a visual indication for keyboard navigation. We need to add a visible border with :focus-visible.

@danilo-leal
Copy link
Contributor

Merging this one as I feel like it's in great shape! If we spot more improvement opportunities, we can always open iterative follow-up PRs 😬 In fact, an obvious one would be adding a dark mode toggle, but, as this might be available within the documentation, I'm assuming the toggle will be there. Anyhow, great work, y'all!

@danilo-leal danilo-leal merged commit dc007ae into mui:master Jan 5, 2024
19 checks passed
mnajdova added a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Co-authored-by: mnajdova <mnajdova@gmail.com>
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants