Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blog] Add post about how MUI uses Toolpad #40172

Merged
merged 41 commits into from Mar 4, 2024
Merged

[blog] Add post about how MUI uses Toolpad #40172

merged 41 commits into from Mar 4, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Dec 11, 2023 •
edited

@mui-bot
Copy link

mui-bot commented Dec 11, 2023 •
edited

Netlify deploy preview

https://deploy-preview-40172--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1460deb

@danilo-leal danilo-leal changed the title Add Toolpad blog: How MUI uses Toolpad. [blog] Add post about how MUI uses Toolpad Dec 11, 2023
@prakhargupta1 prakhargupta1 marked this pull request as ready for review January 9, 2024 07:00
@prakhargupta1 @bharatkashyap
Update docs/pages/blog/2023-toolpad-usage-in-mui.md
b7c4300 
Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
samuelsycamore
samuelsycamore reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece! One last nitpick: I'd drop the year from the file names. Maybe rename to something like toolpad-use-cases to try to get a little bit of SEO in the slug.

docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-toolpad-usage-in-mui.md Outdated Show resolved Hide resolved
prakhargupta1 and others added 3 commits February 21, 2024 23:56
@prakhargupta1 @samuelsycamore
Apply suggestions from Sam's review
bf96c2a 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
@prakhargupta1
more edits
1c3f7b6
@prakhargupta1
replace What's next with Conclusion
bf6e79e
samuelsycamore
samuelsycamore reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid progress—almost there!

docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/public/static/blog/toolpad-use-cases/card.png Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

Rebased on HEAD and fixed the build.

oliviertassinari
oliviertassinari reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

oliviertassinari and others added 7 commits February 26, 2024 01:57
@oliviertassinari
polish
3fd34bf
@oliviertassinari
Fix build
d4bc1c6
@oliviertassinari @samuelsycamore
Sam's review
610f4f7 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari
more sam's review
9035ba9
@oliviertassinari
more polish
b4a4fef
@oliviertassinari
more polish
61dac54
@oliviertassinari
prettier
bd4faa2
@prakhargupta1
Copy link
Member Author

I see Danilo mentioned about the failing tests on some of his PRs. I am assuming this PR falls in the same bucket.
Bringing this to your notice @Janpot. Thanks.

bharatkashyap
bharatkashyap approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Solid content.

docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
docs/pages/blog/toolpad-use-cases.md Outdated Show resolved Hide resolved
@prakhargupta1 prakhargupta1 enabled auto-merge (squash) March 4, 2024 14:37
@prakhargupta1 prakhargupta1 merged commit f58d02e into mui:master Mar 4, 2024
18 checks passed
@prakhargupta1 prakhargupta1 deleted the blog-how-mui-uses-toolpad branch March 4, 2024 14:51
Janpot
Janpot reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@danilo-leal
Copy link
Contributor

We just missed uptading the publishing date, though, it's set to Sunday, March 3th. 😬 Not a big deal, we can adjust it later!

@prakhargupta1
Copy link
Member Author

We just missed uptading the publishing date, though, it's set to Sunday, March 3th. 😬 Not a big deal, we can adjust it later!

Screenshot 2024-03-04 at 9 06 47 PM

It's 4th March, today. Are we checking the same date? 😅

@danilo-leal
Copy link
Contributor

Huh, weird, I see Sunday 😅 Maybe it's timezone-related somehow?

Screenshot 2024-03-04 at 12 55 29

@Janpot Janpot mentioned this pull request Mar 4, 2024
Merged
@samuelsycamore
Copy link
Member

Maybe it's timezone-related somehow?

Yep, I think the T00:00:00.000Z time in the date applies to UTC+00:00, which translates to the day before for those of us to the west of the international date line.

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@prakhargupta1 @bharatkashyap
@samuelsycamore @oliviertassinari @danilo-leal @Janpot @mnajdova
[blog] Add post about how MUI uses Toolpad (mui#40172)
1b9e0d2 
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Co-authored-by: MUI bot <2109932+Janpot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot left review comments

@danilo-leal danilo-leal danilo-leal left review comments

@samuelsycamore samuelsycamore samuelsycamore left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@prakhargupta1 @mui-bot @oliviertassinari @danilo-leal @samuelsycamore @Janpot @bharatkashyap