Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select][material-ui] Add form submission regression test #40176

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Select][material-ui] Add form submission regression test #40176

merged 1 commit into from
Jan 9, 2024

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Dec 11, 2023 •
edited

Related to #40128

This PR adds a test to ensure that the Select's value is not included in the FormData of a form if the name prop/attribute is not explicitly provided

@mj12albert mj12albert added test component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Dec 11, 2023
@mui-bot
Copy link

mui-bot commented Dec 11, 2023 •
edited

Netlify deploy preview

https://deploy-preview-40176--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e83455e

@mj12albert mj12albert force-pushed the material/select-name-regression branch from 7f25a77 to 41c0704 Compare December 11, 2023 13:30
@mj12albert mj12albert mentioned this pull request Dec 11, 2023
Merged
@mj12albert mj12albert force-pushed the material/select-name-regression branch from 41c0704 to 63e4934 Compare December 11, 2023 13:51
@mj12albert
Copy link
Member Author

The test fails before the revert: https://app.circleci.com/pipelines/github/mui/material-ui/115575/workflows/7d2730a8-3438-45db-b234-b5a15d48811e/jobs/620597/parallel-runs/0/steps/0-113

@mj12albert mj12albert force-pushed the material/select-name-regression branch from 63e4934 to d167b41 Compare December 12, 2023 12:26
@mj12albert mj12albert changed the title [Select[material-ui] Add regression test [Select][material-ui] Add regression test Dec 14, 2023
@mj12albert mj12albert force-pushed the material/select-name-regression branch from d167b41 to 09fee90 Compare December 18, 2023 05:10
@mj12albert mj12albert force-pushed the material/select-name-regression branch from 09fee90 to e83455e Compare December 27, 2023 07:02
@mj12albert mj12albert marked this pull request as ready for review December 27, 2023 07:26
@mj12albert mj12albert changed the title [Select][material-ui] Add regression test [Select][material-ui] Add form submission regression test Dec 27, 2023
DiegoAndai
DiegoAndai approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done taking the regression as a opportunity to add a test 😊💯

@siriwatknp siriwatknp merged commit dfbee7e into mui:master Jan 9, 2024
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
@mj12albert @mnajdova
[Select][material-ui] Add form submission regression test (mui#40176)
7469772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mj12albert @mui-bot @DiegoAndai @siriwatknp