Disable menu items #402
Merged
Disable menu items #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Created link and subheader menu components in js/menu/*.
|
Can you please resubmit this PR without build files |
|
Can do. I'll resubmit tonight/tomorrow morning. |
|
Removed build files. |
| }, | ||
|
|
||
| _handleOnClick: function(e) { | ||
| if (this.props.onClick) this.props.onClick(e, this.props.index); | ||
| console.log('inside menu-item click: ' + this.props.disabled); |
There was a problem hiding this comment.
Can you please remove this console log?
Merged
zannager
added
the
component: menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu items can now be disabled. LINK menu items will lose the context menu entries for 'Open In New Tab/Window' if the are disabled. A menu item with a toggle will disable the toggle and the menu item (no hover change) as well as display the default cursor.
Moved the menu components into js/menu/*; the changes to LINK involved some logic that menu should not care about. SUBHEADER was extracted so that MenuItems are consistent. If this is an issue let me know and I'll flatten.