Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix Base UI page's component section imports & styles #40231

Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Dec 18, 2023

Closes #40223

https://deploy-preview-40231--material-ui.netlify.app/base-ui

This PR removed the "Unstyled" suffix from the Base UI component imports on the page's component section.
Also took advantage of the opportunity to fix some stray styles.

@danilo-leal danilo-leal changed the title [website] Fix Base UI pagecomponent section imports & styles [website] Fix Base UI page's component section imports & styles Dec 18, 2023
@danilo-leal danilo-leal added package: base-ui Specific to @mui/base website Pages that are not documentation-related, marketing-focused. labels Dec 18, 2023
@mui-bot
Copy link

mui-bot commented Dec 18, 2023

Netlify deploy preview

https://deploy-preview-40231--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d7516b3

@danilo-leal
Copy link
Contributor Author

danilo-leal commented Jan 2, 2024

@michaldudak — mind taking a second look here? 🙏

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. As a side note, I'm wondering if we shouldn't promote passing unstyled components to the styled utility instead of using the root slot - it's shorter:

const Tab = styled(BaseTab)`...`;

<Tab />

@danilo-leal danilo-leal merged commit 48f677e into mui:master Jan 3, 2024
19 checks passed
@danilo-leal danilo-leal deleted the fix-base-page-components-section branch January 3, 2024 12:41
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: base-ui Specific to @mui/base website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[website] On the Base UI page, the components section have imports with the old "unstyled" suffix
3 participants