[base-ui][useSlider] rearrange passive option in eventlisteners #40235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40235--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
component: slider
zannager
requested review from
mnajdova and
michaldudak
and removed request for
mnajdova
michaldudak
reviewed
Dec 22, 2023
| slider!.addEventListener('touchstart', handleTouchStart, { | ||
| passive: doesSupportTouchActionNone(), | ||
| }); | ||
| slider!.addEventListener('touchstart', handleTouchStart); |
There was a problem hiding this comment.
This can remain as it was before. Only the removeEventListener function doesn't need the third parameter.
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
…40235) Co-authored-by: Ragim Musakaev <ragim@panoramik.ru>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @pixelass in issue 39365, I removed unnecessary eventListener passive options and added them where needed