Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Adding autoFocus on Virtual Popover #40239

Merged

Conversation

aacevski
Copy link
Contributor

@aacevski aacevski commented Dec 18, 2023

Preview: https://deploy-preview-40239--material-ui.netlify.app/material-ui/react-popover/#virtual-element

Closes #40137

The issue was that with the Popover opening, the selection lost focus on Safari, disabling the autoFocus fixes this issue.

- The issue was that with the Popover opening, the selection lost focus on Safari, disabling the autoFocus fixes this issue
@aacevski aacevski changed the title bugfix: Adding autoFocus on Virtual Popover [material-ui][docs] Adding autoFocus on Virtual Popover Dec 18, 2023
@mui-bot
Copy link

mui-bot commented Dec 18, 2023

Netlify deploy preview

https://deploy-preview-40239--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3c3c2f6

@zannager zannager added docs Improvements or additions to the documentation component: Popover The React component. labels Dec 19, 2023
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Dec 22, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 It's a great first pull request on MUI! I hope to see many more :)

@aacevski
Copy link
Contributor Author

LGTM 👍 It's a great first pull request on MUI! I hope to see many more :)

You got it! 🙌🏼

@mj12albert mj12albert merged commit c9ffe84 into mui:master Dec 28, 2023
22 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component. docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Demo VirtualElementPopover crashes
6 participants