Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][docs] Polish the Table Pagination demos #40281

Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Dec 22, 2023

This PR adds a coat of polish to the Table Pagination demos, as I just recently discovered the ability to change the action button's default icons. 馃槵 It's something we're not doing a great job of documenting (maybe through exploring the package's code, I'd be able to figure it out, but the docs didn't mention it at all). Hopefully, the demos will now be able to showcase that! I also removed the Tailwind/Plain CSS option from the customized look and feel demo, keeping it just for the introduction demo.

https://deploy-preview-40281--material-ui.netlify.app/base-ui/react-table-pagination/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Dec 22, 2023
@danilo-leal danilo-leal requested review from michaldudak and a team December 22, 2023 21:44
@danilo-leal danilo-leal self-assigned this Dec 22, 2023
@mui-bot
Copy link

mui-bot commented Dec 22, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 馃毇 dangerJS against 4ce5098

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement!

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@danilo-leal danilo-leal merged commit c4d42f9 into mui:master Dec 28, 2023
19 checks passed
@danilo-leal danilo-leal deleted the customize-base-table-pagination-demos branch December 28, 2023 03:38
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants