-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[base-ui][docs] Polish the Table Pagination demos #40281
Merged
danilo-leal
merged 6 commits into
mui:master
from
danilo-leal:customize-base-table-pagination-demos
Dec 28, 2023
Merged
[base-ui][docs] Polish the Table Pagination demos #40281
danilo-leal
merged 6 commits into
mui:master
from
danilo-leal:customize-base-table-pagination-demos
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Improvements or additions to the documentation
design
This is about UI or UX design, please involve a designer
package: base-ui
Specific to @mui/base
labels
Dec 22, 2023
Netlify deploy previewBundle size report |
michaldudak
reviewed
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an improvement!
michaldudak
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
This is about UI or UX design, please involve a designer
docs
Improvements or additions to the documentation
package: base-ui
Specific to @mui/base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a coat of polish to the Table Pagination demos, as I just recently discovered the ability to change the action button's default icons. 馃槵 It's something we're not doing a great job of documenting (maybe through exploring the package's code, I'd be able to figure it out, but the docs didn't mention it at all). Hopefully, the demos will now be able to showcase that! I also removed the Tailwind/Plain CSS option from the customized look and feel demo, keeping it just for the introduction demo.
https://deploy-preview-40281--material-ui.netlify.app/base-ui/react-table-pagination/