[docs-infra] Fix footer links to link to the main domain #40373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-40373--material-ui.netlify.app/ Bundle size report |
danilo-leal
added
scope: docs-infra
danilo-leal
changed the title
danilo-leal
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't have the links be a relative URL
/blog/they need to be an absolute URLhttps://mui.com/blog/. This is because once the current version of the docs is archived, e.g. to a subdomain: https://v4.mui.com/, we don't want the links to the blog to point to https://v4.mui.com/blog/Future. Some docs like Hashicorp store their docs as subfolders https://developer.hashicorp.com/terraform/language/v1.7.x, we could do this, it's not hard, allowing to revert this PR, but we don't do it currently. I have no idea if a subfolder is better than a subdomain for historized docs, we never really poured much thought into it.