Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix a11y violation rule #40393

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 1, 2024

Fix one of the reports from https://pagespeed.web.dev/analysis/https-mui-com-material-ui-react-button/zomrvia5y0?form_factor=desktop

Screenshot 2024-01-01 at 21 12 42

We were not respecting this rule https://dequeuniversity.com/rules/axe/4.7/label-content-name-mismatch.

Part of the value of this fix is to remove the noise from the docs-infra so we can more easily spot the issues on our components.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work accessibility a11y scope: docs-infra Specific to the docs-infra product labels Jan 1, 2024
@mui-bot
Copy link

mui-bot commented Jan 1, 2024

Netlify deploy preview

https://deploy-preview-40393--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a24fab3

@oliviertassinari oliviertassinari merged commit 8c3423c into mui:master Jan 2, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the aria-label-match-visual branch January 2, 2024 15:40
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants