[material-nextjs] Fix order of emotion server #40409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
commented
Jan 3, 2024
Netlify deploy previewhttps://deploy-preview-40409--material-ui.netlify.app/ Bundle size report |
mnajdova
approved these changes
Jan 3, 2024
…3.tsx Signed-off-by: Marija Najdova <mnajdova@gmail.com>
|
@siriwatknp Thanks for fixing this regression 👍 . I noticed it because https://validator.w3.org/nu/?doc=https%3A%2F%2F658990a51b4291000981a3bd--material-ui-docs.netlify.app%2F would spam so many errors:
|
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createEmotionServerhas to be called directly after cache creation due to the side effect ofcache.compat = true, otherwise the<style>tag will not come with the HTML string from the server.