[code-infra] Use tsx instead of ts-node #40428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40428--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Jan 4, 2024
| @@ -34,7 +34,7 @@ | |||
| "docs:typescript:formatted": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" ./docs/scripts/formattedTSDemos", | |||
| "docs:mdicons:synonyms": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js,.mjs\" ./docs/scripts/updateIconSynonyms && pnpm prettier", | |||
| "extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 8 build:modern", | |||
| "rsc:build": "ts-node ./packages/rsc-builder/buildRsc.ts", | |||
| "rsc:build": "tsx ./packages/rsc-builder/buildRsc.ts", | |||
There was a problem hiding this comment.
If we don't want to depend on either (ts-node, tsx), this would work as well (has a slower startup time):
Suggested change
| "rsc:build": "tsx ./packages/rsc-builder/buildRsc.ts", | |
| "rsc:build": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" ./packages/rsc-builder/buildRsc.ts", |
There was a problem hiding this comment.
babel-node is problematic when running ESM scripts. It doesn't read tsconfig, so we're can't set module and resolution strategy (at least not as simply as in tsconfig). I'd rather use tsconfigs for this and slowly phase Babel away (to be able to use SWC in Next JS).
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ts-node having problems with newer versions of Node (TypeStrong/ts-node#2094) and being hard to configure properly with aliases (problems such as https://app.circleci.com/pipelines/github/mui/material-ui/117126/workflows/61940872-34d1-443b-bb13-9b0b87eaa785/jobs/629297, https://app.circleci.com/pipelines/github/mui/material-ui/117126/workflows/61940872-34d1-443b-bb13-9b0b87eaa785/jobs/629298, and numerous others surfaced during the pnpm migration), I decided to replace it with tsx.
It just works, without the need of installing additional path resolvers, no matter if the script is ESM or CJS. With tsx the issues on CI I linked above are gone.
With this change, I also unpinned the Node version on the CI.