[system] Fix build size with material-ui-nextjs #40436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
bug 🐛
siriwatknp
force-pushed
the
fix/pages-router-bundle
branch
from
a6bb717
to
8ef1c81
Compare
…pages-router-bundle
github-actions
bot
added
the
PR: out-of-date
Netlify deploy previewhttps://deploy-preview-40436--material-ui.netlify.app/ Bundle size report |
github-actions
bot
removed
the
PR: out-of-date
mnajdova
approved these changes
Jan 5, 2024
oliviertassinari
changed the title
oliviertassinari
added
package: system
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
|
After upgrading the package, there is typescript error which says the module "@mui/material-nextjs" doesn't exist |
|
@songhobby have you created issue about it? It's hard to follow notifications on closed PRs. cc @siriwatknp in case you missed the notification too. Apologies if it has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40203
The root cause comes from the import of
next/documentin the same file asAppCacheProviderwhich includes unnecessary javascript to the output of_app.js.Fixed by splitting the files into document and app files.
Before:
After:
Testing
clone the material-ui-nextjs-pages-router-ts example
Run
yarn && yarn buildto see the issue (similar to Before image)Open
package.jsonand replace the@mui/material-nextjsversion withhttps://pkg.csb.dev/mui/material-ui/commit/2d5cbbca/@mui/material.Delete the
.nextfolder and runyarn && yarn buildagain (the bundle size should be green)