Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove duplicate devDependencies #40438

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 5, 2024

Removed packages duplicated between dependencies and devDependencies. They are used by the Netlify function, so they should live in dependencies.

Also log warnings:

Screenshot 2024-01-06 at 19 06 30

@michaldudak michaldudak added the scope: code-infra Specific to the core-infra product label Jan 5, 2024
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 5, 2024
@mui-bot
Copy link

mui-bot commented Jan 5, 2024

Netlify deploy preview

https://deploy-preview-40438--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ba7a245

@oliviertassinari oliviertassinari changed the title [code-infra] Remove duplicate devDependencies [core] Remove duplicate devDependencies Jan 6, 2024
@oliviertassinari oliviertassinari removed the scope: code-infra Specific to the core-infra product label Jan 6, 2024
@michaldudak michaldudak requested a review from a team January 8, 2024 10:35
@michaldudak michaldudak marked this pull request as ready for review January 8, 2024 10:36
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 8, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2024
@michaldudak michaldudak enabled auto-merge (squash) January 8, 2024 19:24
@michaldudak michaldudak merged commit 48a2922 into mui:master Jan 8, 2024
18 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants