[material-ui][Dialog] Refactor form submission in FormDialog component #40470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewhttps://deploy-preview-40470--material-ui.netlify.app/ Bundle size report |
|
This reminds me a bit of #13253. We might want to apply #13253 (comment). |
2 tasks
DiegoAndai
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Looks good to me 🚀
I'll hold on merging to see if @oliviertassinari has anything else to add
|
It looks good 👍 |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: https://mui-org.slack.com/archives/C041SDSF32L/p1704573701949879?thread_ts=1704447600.158559&cid=C041SDSF32L and #13253 (comment)
Preview: https://deploy-preview-40470--material-ui.netlify.app/material-ui/react-dialog/#form-dialogs