[code-infra] Explain how to install the browsers #40474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40474--material-ui.netlify.app/ Bundle size report |
oliviertassinari
commented
Jan 7, 2024
| - Headless Firefox | ||
| - Chrome, Safari, and Edge thanks to [BrowserStack](https://www.browserstack.com) | ||
|
|
||
| In development mode, if `pnpm test:karma` fails with this error "Cannot start ChromeHeadless. Can not find the binary", you can solve it by installing the missing headless browsers: `pnpm playwright install --with-deps`. |
There was a problem hiding this comment.
Copies:
material-ui/.circleci/config.yml
Line 109 in 5518265
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't so obvious to me how to debug:
Applies to MUI X, Material UI, etc.
This is required now because of the change made in https://github.com/microsoft/playwright/releases/tag/v1.38.0. A much better solution would be to catch the error and log the right error message but I didn't have the time to look into this.