Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix API table full-width #40476

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 7, 2024

I was triggered by overflow: hidden, this is 99% of the time a red flag. Turns out, we can improve the table view. The solution reproduces the stable used by the Material UI Table (same as Bootstrap).

Before https://mui.com/base-ui/react-menu/components-api/#menu-item-slots

After https://deploy-preview-40476--material-ui.netlify.app/base-ui/react-menu/components-api/#menu-item-slots

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Jan 7, 2024
@mui-bot
Copy link

mui-bot commented Jan 7, 2024

Netlify deploy preview

https://deploy-preview-40476--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a1d0b23

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! (Removed the bug label, though — feels more like an improvement that something that wasn't working).

@danilo-leal danilo-leal removed the bug 🐛 Something doesn't work label Jan 8, 2024
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Jan 8, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Fix table full-width [docs-infra] Fix API table full-width Jan 8, 2024
@oliviertassinari oliviertassinari merged commit c7788e9 into mui:master Jan 8, 2024
21 checks passed
@oliviertassinari oliviertassinari deleted the api-fix-table-full-width branch January 8, 2024 12:44
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants