[code-infra] Configure build dependencies in nx #40482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40482--material-ui.netlify.app/ Bundle size report |
brijeshb42
reviewed
Jan 8, 2024
| @@ -3,7 +3,8 @@ | |||
| "extends": "nx/presets/npm.json", | |||
| "targetDefaults": { | |||
| "build": { | |||
| "cache": true | |||
| "cache": true, | |||
| "dependsOn": ["^build"] | |||
There was a problem hiding this comment.
👍🏼 I also added the same thing in my PR but then did not try to run lerna, instead continued with nx.
brijeshb42
approved these changes
Jan 8, 2024
Janpot
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
I guess we could take an even deeper look at this and express the whole build command with dependencies? It could improve overall build time by giving nx more pieces to parallelize. non-blocking for this PR of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure Lerna to look for project dependencies when running the
buildcommand.This should solve the issue described in #40426 (comment)