Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-nextjs] Add theming and configuration content to the page #40626

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 16, 2024

@siriwatknp siriwatknp added docs Improvements or additions to the documentation nextjs labels Jan 16, 2024
@mui-bot
Copy link

mui-bot commented Jan 16, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6da1dbd

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this!

@@ -47,6 +47,88 @@ Inside `app/layout.tsx`, import the `AppRouterCacheProvider` and wrap all elemen
}
```

### Custom cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason or benefit of doing this? (Why would a user take this step?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 2 cases:

  1. They have their own stylisPlugins that they want to use, e.g. emotion has a bug with :where selector, using a custom stylisPlugins is a workaround that we are doing in our doc.
  2. They want to change the default CSS key (mui) to something else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it—I think we could explain this here, and maybe mention that it's not required. I could see this being confusing if you don't know whether or not you need to do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelsycamore I move it under h4 as a content of Configuration and with optional at the end ### Custom cache (optional).

What do you think?

docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
docs/data/material/guides/nextjs/nextjs.md Outdated Show resolved Hide resolved
siriwatknp and others added 2 commits January 17, 2024 11:05
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@siriwatknp siriwatknp merged commit 80c7f72 into mui:master Jan 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][docs] Expand the @mui/material-nextjs integration package doc
4 participants